vspadmin: Reject private keys in fee xpub config.

The provided key should always be a public key, enforcing this in
software provides an extra safety net for users.
This commit is contained in:
jholdstock 2024-06-06 11:10:33 +01:00 committed by Jamie Holdstock
parent 4e5fec8f3b
commit 1fa81d3697

View File

@ -5,6 +5,7 @@
package main package main
import ( import (
"errors"
"fmt" "fmt"
"os" "os"
"path/filepath" "path/filepath"
@ -54,11 +55,16 @@ func createDatabase(homeDir string, feeXPub string, network *config.Network) err
} }
// Ensure provided xpub is a valid key for the selected network. // Ensure provided xpub is a valid key for the selected network.
_, err := hdkeychain.NewKeyFromString(feeXPub, network.Params) feeXpub, err := hdkeychain.NewKeyFromString(feeXPub, network.Params)
if err != nil { if err != nil {
return fmt.Errorf("failed to parse feexpub: %w", err) return fmt.Errorf("failed to parse feexpub: %w", err)
} }
// Ensure key is public.
if feeXpub.IsPrivate() {
return errors.New("feexpub is a private key, should be public")
}
// Ensure the data directory exists. // Ensure the data directory exists.
err = os.MkdirAll(dataDir, 0700) err = os.MkdirAll(dataDir, 0700)
if err != nil { if err != nil {