Handle "transaction already exists" error

background/background.go

@@ -94,8 +94,6 @@ func blockConnected() {
 	for _, ticket := range pending {
 		feeTxHash, err := dcrdClient.SendRawTransaction(ticket.FeeTxHex)
 		if err != nil {
-			// TODO: SendRawTransaction can return a "transcation already
-			// exists" error, which isnt necessarily a problem here.
 			log.Errorf("SendRawTransaction error: %v", err)
 			continue
 		}

rpc/dcrd.go

@@ -5,6 +5,7 @@ import (
 	"encoding/hex"
 	"errors"
 	"fmt"
+	"strings"
 	"sync"
 
 	"github.com/decred/dcrd/blockchain/stake/v3"
@@ -100,8 +101,25 @@ func (c *DcrdRPC) SendRawTransaction(txHex string) (string, error) {
 	var txHash string
 	err := c.Call(c.ctx, "sendrawtransaction", &txHash, txHex, allowHighFees)
 	if err != nil {
+		// It's not a problem if the transaction has already been broadcast,
+		// just need to calculate and return its hash.
+		if !strings.Contains(err.Error(), "transaction already exists") {
 			return "", err
 		}
+
+		msgHex, err := hex.DecodeString(txHex)
+		if err != nil {
+			return "", fmt.Errorf("DecodeString error: %v", err)
+
+		}
+		msgTx := wire.NewMsgTx()
+		if err = msgTx.FromBytes(msgHex); err != nil {
+			return "", fmt.Errorf("FromBytes error: %v", err)
+
+		}
+
+		txHash = msgTx.TxHash().String()
+	}
 	return txHash, nil
 }
 

webapi/payfee.go

@@ -215,8 +215,6 @@ findAddress:
 	if ticket.Confirmed {
 		feeTxHash, err := dcrdClient.SendRawTransaction(payFeeRequest.FeeTx)
 		if err != nil {
-			// TODO: SendRawTransaction can return a "transcation already
-			// exists" error, which isnt necessarily a problem here.
 			log.Errorf("SendRawTransaction failed: %v", err)
 			sendErrorResponse("dcrwallet RPC error", http.StatusInternalServerError, c)
 			return