stakey/vspd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Dont use byte slices outside of db tx.

Browse Source
This commit is contained in:
jholdstock 2020-06-16 13:49:06 +01:00 committed by David Hill
parent a9d70abb93
commit 5a1a1b487e
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
database/database.go
View File

@ -196,7 +196,13 @@ func (vdb *VspDatabase) KeyPair() (ed25519.PrivateKey, ed25519.PublicKey, error)
err := vdb.db.View(func(tx *bolt.Tx) error { err := vdb.db.View(func(tx *bolt.Tx) error {
vspBkt := tx.Bucket(vspBktK) vspBkt := tx.Bucket(vspBktK)
seed = vspBkt.Get(privateKeyK) s := vspBkt.Get(privateKeyK)
// Byte slices returned from Bolt are only valid during a transaction.
// Need to make a copy.
seed = make([]byte, len(s))
copy(seed, s)
if seed == nil { if seed == nil {
// should not happen // should not happen
return fmt.Errorf("no private key found") return fmt.Errorf("no private key found")
@ -242,7 +248,12 @@ func (vdb *VspDatabase) GetCookieSecret() ([]byte, error) {
err := vdb.db.View(func(tx *bolt.Tx) error { err := vdb.db.View(func(tx *bolt.Tx) error {
vspBkt := tx.Bucket(vspBktK) vspBkt := tx.Bucket(vspBktK)
cookieSecret = vspBkt.Get(cookieSecretK) cs := vspBkt.Get(cookieSecretK)
// Byte slices returned from Bolt are only valid during a transaction.
// Need to make a copy.
cookieSecret = make([]byte, len(cs))
copy(cookieSecret, cs)
return nil return nil
}) })