types: Use ErrorCode in ErrorResponse.

Using ErrorCode instead of int64 in the ErrorResponse type removes the burden of type conversion from calling code.
This commit is contained in:
jholdstock 2023-03-16 15:54:39 +00:00 committed by Jamie Holdstock
parent 8303aa8536
commit 6d78e16b23
3 changed files with 8 additions and 8 deletions

View File

@ -1,3 +1,3 @@
module github.com/decred/vspd/types
module github.com/decred/vspd/types/v2
go 1.19

View File

@ -1,12 +1,12 @@
// Copyright (c) 2020-2022 The Decred developers
// Copyright (c) 2020-2023 The Decred developers
// Use of this source code is governed by an ISC
// license that can be found in the LICENSE file.
package types
type ErrorResponse struct {
Code int64 `json:"code"`
Message string `json:"message"`
Code ErrorCode `json:"code"`
Message string `json:"message"`
}
func (e ErrorResponse) Error() string { return e.Message }

View File

@ -1,4 +1,4 @@
// Copyright (c) 2022 The Decred developers
// Copyright (c) 2022-2023 The Decred developers
// Use of this source code is governed by an ISC
// license that can be found in the LICENSE file.
@ -18,12 +18,12 @@ func TestAPIErrorAs(t *testing.T) {
expectedMessage string
}{
"BadRequest error": {
apiError: ErrorResponse{Message: "something went wrong", Code: int64(ErrBadRequest)},
apiError: ErrorResponse{Message: "something went wrong", Code: ErrBadRequest},
expectedKind: ErrBadRequest,
expectedMessage: "something went wrong",
},
"Unknown error": {
apiError: ErrorResponse{Message: "something went wrong again", Code: int64(999)},
apiError: ErrorResponse{Message: "something went wrong again", Code: 999},
expectedKind: 999,
expectedMessage: "something went wrong again",
},
@ -38,7 +38,7 @@ func TestAPIErrorAs(t *testing.T) {
t.Fatalf("unable to unwrap error")
}
if parsedError.Code != int64(test.expectedKind) {
if parsedError.Code != test.expectedKind {
t.Fatalf("error was wrong kind. expected: %d actual %d",
test.expectedKind, parsedError.Code)
}