stakey/vspd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

multi: Remove GetBlockHeaderVerbose.

Browse Source 
A slight performance improvement becase vspd can do everything it needs
without the verbose block header.
This commit is contained in:
jholdstock 2023-08-31 10:38:01 +01:00 committed by Jamie Holdstock
parent fb47e65ef3
commit 7d1b7deb01
2 changed files with 3 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
rpc/dcrd.go
View File

@ -223,14 +223,14 @@ func (c *DcrdRPC) NotifyBlocks() error {
// GetBestBlockHeader uses getbestblockhash RPC, followed by getblockheader RPC, // GetBestBlockHeader uses getbestblockhash RPC, followed by getblockheader RPC,
// to retrieve the header of the best block known to the dcrd instance. // to retrieve the header of the best block known to the dcrd instance.
func (c *DcrdRPC) GetBestBlockHeader() (*dcrdtypes.GetBlockHeaderVerboseResult, error) { func (c *DcrdRPC) GetBestBlockHeader() (*wire.BlockHeader, error) {
var bestBlockHash string var bestBlockHash string
err := c.Call(context.TODO(), "getbestblockhash", &bestBlockHash) err := c.Call(context.TODO(), "getbestblockhash", &bestBlockHash)
if err != nil { if err != nil {
return nil, err return nil, err
} }
blockHeader, err := c.GetBlockHeaderVerbose(bestBlockHash) blockHeader, err := c.GetBlockHeader(bestBlockHash)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -263,18 +263,6 @@ func (c *DcrdRPC) GetBlockHeader(blockHash string) (*wire.BlockHeader, error) {
return &blockHeader, nil return &blockHeader, nil
} }
// GetBlockHeaderVerbose uses getblockheader RPC with verbose=true to retrieve
// the header of the requested block.
func (c *DcrdRPC) GetBlockHeaderVerbose(blockHash string) (*dcrdtypes.GetBlockHeaderVerboseResult, error) {
const verbose = true
var blockHeader dcrdtypes.GetBlockHeaderVerboseResult
err := c.Call(context.TODO(), "getblockheader", &blockHeader, blockHash, verbose)
if err != nil {
return nil, err
}
return &blockHeader, nil
}
// ExistsLiveTicket uses existslivetickets RPC to check if the provided ticket // ExistsLiveTicket uses existslivetickets RPC to check if the provided ticket
// hash is a live ticket known to the dcrd instance. // hash is a live ticket known to the dcrd instance.
func (c *DcrdRPC) ExistsLiveTicket(ticketHash string) (bool, error) { func (c *DcrdRPC) ExistsLiveTicket(ticketHash string) (bool, error) {

5
webapi/getfeeaddress.go
View File

@ -49,10 +49,7 @@ func (s *Server) getCurrentFee(dcrdClient *rpc.DcrdRPC) (dcrutil.Amount, error)
return 0, err return 0, err
} }
sDiff, err := dcrutil.NewAmount(bestBlock.SBits) sDiff := dcrutil.Amount(bestBlock.SBits)
if err != nil {
return 0, err
}
// Using a hard-coded amount for relay fee is acceptable here because this // Using a hard-coded amount for relay fee is acceptable here because this
// amount is never actually used to construct or broadcast transactions. It // amount is never actually used to construct or broadcast transactions. It