stakey/vspd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove duplicate fee addr check. (#361)

Browse Source 
This check was added preemptively, the error has never actually been observed in dev, testing, or production.

It does not scale well. Its takes almost 500ms to insert into a database containing 100k tickets.
This commit is contained in:
Jamie Holdstock 2022-12-01 13:08:18 +08:00 committed by GitHub
parent 4acd57efbc
commit 824c41c2a5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
database/ticket.go
View File

@ -113,20 +113,6 @@ func (vdb *VspDatabase) InsertNewTicket(ticket Ticket) error {
return fmt.Errorf("could not create bucket for ticket: %w", err) return fmt.Errorf("could not create bucket for ticket: %w", err)
} }
// Error if a ticket already exists with the same fee address.
err = ticketBkt.ForEach(func(k, v []byte) error {
tbkt := ticketBkt.Bucket(k)
if string(tbkt.Get(feeAddressK)) == ticket.FeeAddress {
return fmt.Errorf("ticket with fee address %s already exists", ticket.FeeAddress)
}
return nil
})
if err != nil {
return err
}
err = putTicketInBucket(newTicketBkt, ticket) err = putTicketInBucket(newTicketBkt, ticket)
if err != nil { if err != nil {
return fmt.Errorf("putting ticket in bucket failed: %w", err) return fmt.Errorf("putting ticket in bucket failed: %w", err)

8
database/ticket_test.go
View File

@ -53,14 +53,6 @@ func testInsertNewTicket(t *testing.T) {
t.Fatal("expected an error inserting ticket with duplicate hash") t.Fatal("expected an error inserting ticket with duplicate hash")
} }
// Inserting a ticket with the same fee address should fail.
ticket3 := exampleTicket()
ticket3.FeeAddress = ticket.FeeAddress
err = db.InsertNewTicket(ticket3)
if err == nil {
t.Fatal("expected an error inserting ticket with duplicate fee addr")
}
// Inserting a ticket with empty hash should fail. // Inserting a ticket with empty hash should fail.
ticket.Hash = "" ticket.Hash = ""
err = db.InsertNewTicket(ticket) err = db.InsertNewTicket(ticket)