From e2483b6cea7fef12db18fafdb28e305d2d637fa0 Mon Sep 17 00:00:00 2001 From: jholdstock Date: Sun, 9 Aug 2020 10:30:55 +0100 Subject: [PATCH] Fix backup file mode --- database/database.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/database/database.go b/database/database.go index 55041fd..a8eb7c9 100644 --- a/database/database.go +++ b/database/database.go @@ -43,6 +43,11 @@ var ( lastAddressIndexK = []byte("lastaddressindex") ) +const ( + // backupFileMode is the file mode for database backup files written by vspd. + backupFileMode = 0600 +) + // backupMtx should be held when writing to the database backup file var backupMtx sync.Mutex @@ -57,7 +62,7 @@ func writeHotBackupFile(db *bolt.DB) error { // Write backup to temporary file. err := db.View(func(tx *bolt.Tx) error { - return tx.CopyFile(tempPath, 0600) + return tx.CopyFile(tempPath, backupFileMode) }) if err != nil { return fmt.Errorf("tx.CopyFile: %v", err) @@ -229,7 +234,7 @@ func (vdb *VspDatabase) Close() { } defer from.Close() - to, err := os.OpenFile(tempPath, os.O_RDWR|os.O_CREATE, 0666) + to, err := os.OpenFile(tempPath, os.O_RDWR|os.O_CREATE, backupFileMode) if err != nil { log.Errorf("Failed to write a database backup (os.OpenFile): %v", err) return