multi: Use const where possible.

database/votechange_test.go

@@ -19,7 +19,7 @@ func exampleRecord() VoteChangeRecord {
 }
 
 func testVoteChangeRecords(t *testing.T) {
-	hash := "MyHash"
+	const hash = "MyHash"
 	record := exampleRecord()
 
 	// Insert a record into the database.

internal/webapi/helpers_test.go

@@ -57,8 +57,8 @@ func TestIsValidVoteChoices(t *testing.T) {
 func TestIsValidTSpendPolicy(t *testing.T) {
 
 	// A valid tspend hash is 32 bytes (64 characters).
-	validHash := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+	const validHash = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
-	anotherValidHash := "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
+	const anotherValidHash = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
 
 	var tests = []struct {
 		tspendPolicy map[string]string
@@ -102,8 +102,8 @@ func TestIsValidTSpendPolicy(t *testing.T) {
 func TestIsValidTreasuryPolicy(t *testing.T) {
 
 	// A valid treasury key is 33 bytes (66 characters).
-	validKey := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+	const validKey = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
-	anotherValidKey := "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
+	const anotherValidKey = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
 
 	var tests = []struct {
 		treasuryPolicy map[string]string

internal/webapi/setaltsignaddr.go

@@ -56,7 +56,7 @@ func (w *WebAPI) setAltSignAddr(c *gin.Context) {
 		return
 	}
 	if currentData != nil {
-		msg := "alternate sign address data already exists"
+		const msg = "alternate sign address data already exists"
 		w.log.Warnf("%s: %s (ticketHash=%s)", funcName, msg, ticketHash)
 		w.sendErrorWithMsg(msg, types.ErrBadRequest, c)
 		return