Checking this in middleware not only removes duplicated code from each of the handlers, but also makes things more efficient. Previously, dcrd/dcrwallet/database clients were initialized (and could possibly cause errors) **before** checking if the VSP is closed. Now the check happens before those other things. Also bundled with some improvements to setaltsignaddr_test.go which I implemented along the way.
309 lines
9.7 KiB
Go
309 lines
9.7 KiB
Go
// Copyright (c) 2020-2022 The Decred developers
|
|
// Use of this source code is governed by an ISC
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package webapi
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/decred/dcrd/blockchain/v4"
|
|
"github.com/decred/dcrd/dcrutil/v4"
|
|
"github.com/decred/dcrd/txscript/v4/stdaddr"
|
|
"github.com/decred/vspd/database"
|
|
"github.com/decred/vspd/rpc"
|
|
"github.com/decred/vspd/types"
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/gin-gonic/gin/binding"
|
|
)
|
|
|
|
// payFee is the handler for "POST /api/v3/payfee".
|
|
func (s *Server) payFee(c *gin.Context) {
|
|
const funcName = "payFee"
|
|
|
|
// Get values which have been added to context by middleware.
|
|
ticket := c.MustGet(ticketKey).(database.Ticket)
|
|
knownTicket := c.MustGet(knownTicketKey).(bool)
|
|
dcrdClient := c.MustGet(dcrdKey).(*rpc.DcrdRPC)
|
|
dcrdErr := c.MustGet(dcrdErrorKey)
|
|
if dcrdErr != nil {
|
|
s.log.Errorf("%s: Could not get dcrd client: %v", funcName, dcrdErr.(error))
|
|
s.sendError(types.ErrInternalError, c)
|
|
return
|
|
}
|
|
reqBytes := c.MustGet(requestBytesKey).([]byte)
|
|
|
|
if !knownTicket {
|
|
s.log.Warnf("%s: Unknown ticket (clientIP=%s)", funcName, c.ClientIP())
|
|
s.sendError(types.ErrUnknownTicket, c)
|
|
return
|
|
}
|
|
|
|
var request types.PayFeeRequest
|
|
if err := binding.JSON.BindBody(reqBytes, &request); err != nil {
|
|
s.log.Warnf("%s: Bad request (clientIP=%s): %v", funcName, c.ClientIP(), err)
|
|
s.sendErrorWithMsg(err.Error(), types.ErrBadRequest, c)
|
|
return
|
|
}
|
|
|
|
// Respond early if we already have the fee tx for this ticket.
|
|
if ticket.FeeTxStatus == database.FeeReceieved ||
|
|
ticket.FeeTxStatus == database.FeeBroadcast ||
|
|
ticket.FeeTxStatus == database.FeeConfirmed {
|
|
s.log.Warnf("%s: Fee tx already received (clientIP=%s, ticketHash=%s)",
|
|
funcName, c.ClientIP(), ticket.Hash)
|
|
s.sendError(types.ErrFeeAlreadyReceived, c)
|
|
return
|
|
}
|
|
|
|
// Get ticket details.
|
|
rawTicket, err := dcrdClient.GetRawTransaction(ticket.Hash)
|
|
if err != nil {
|
|
s.log.Errorf("%s: dcrd.GetRawTransaction for ticket failed (ticketHash=%s): %v", funcName, ticket.Hash, err)
|
|
s.sendError(types.ErrInternalError, c)
|
|
return
|
|
}
|
|
|
|
// Ensure this ticket is eligible to vote at some point in the future.
|
|
canVote, err := canTicketVote(rawTicket, dcrdClient, s.cfg.NetParams)
|
|
if err != nil {
|
|
s.log.Errorf("%s: canTicketVote error (ticketHash=%s): %v", funcName, ticket.Hash, err)
|
|
s.sendError(types.ErrInternalError, c)
|
|
return
|
|
}
|
|
if !canVote {
|
|
s.log.Warnf("%s: Unvotable ticket (clientIP=%s, ticketHash=%s)",
|
|
funcName, c.ClientIP(), ticket.Hash)
|
|
s.sendError(types.ErrTicketCannotVote, c)
|
|
return
|
|
}
|
|
|
|
// Respond early if the fee for this ticket is expired.
|
|
if ticket.FeeExpired() {
|
|
s.log.Warnf("%s: Expired payfee request (clientIP=%s, ticketHash=%s)",
|
|
funcName, c.ClientIP(), ticket.Hash)
|
|
s.sendError(types.ErrFeeExpired, c)
|
|
return
|
|
}
|
|
|
|
// Validate VotingKey.
|
|
votingKey := request.VotingKey
|
|
votingWIF, err := dcrutil.DecodeWIF(votingKey, s.cfg.NetParams.PrivateKeyID)
|
|
if err != nil {
|
|
s.log.Warnf("%s: Failed to decode WIF (clientIP=%s, ticketHash=%s): %v",
|
|
funcName, c.ClientIP(), ticket.Hash, err)
|
|
s.sendError(types.ErrInvalidPrivKey, c)
|
|
return
|
|
}
|
|
|
|
// Validate voting prefences. Just log a warning if anything is invalid -
|
|
// the ticket should still be registered.
|
|
|
|
validVoteChoices := true
|
|
err = validConsensusVoteChoices(s.cfg.NetParams, currentVoteVersion(s.cfg.NetParams), request.VoteChoices)
|
|
if err != nil {
|
|
validVoteChoices = false
|
|
s.log.Warnf("%s: Invalid consensus vote choices (clientIP=%s, ticketHash=%s): %v",
|
|
funcName, c.ClientIP(), ticket.Hash, err)
|
|
}
|
|
|
|
validTreasury := true
|
|
err = validTreasuryPolicy(request.TreasuryPolicy)
|
|
if err != nil {
|
|
validTreasury = false
|
|
s.log.Warnf("%s: Invalid treasury policy (clientIP=%s, ticketHash=%s): %v",
|
|
funcName, c.ClientIP(), ticket.Hash, err)
|
|
}
|
|
|
|
validTSpend := true
|
|
err = validTSpendPolicy(request.TSpendPolicy)
|
|
if err != nil {
|
|
validTSpend = false
|
|
s.log.Warnf("%s: Invalid tspend policy (clientIP=%s, ticketHash=%s): %v",
|
|
funcName, c.ClientIP(), ticket.Hash, err)
|
|
}
|
|
|
|
// Validate FeeTx.
|
|
feeTx, err := decodeTransaction(request.FeeTx)
|
|
if err != nil {
|
|
s.log.Warnf("%s: Failed to decode fee tx hex (clientIP=%s, ticketHash=%s): %v",
|
|
funcName, c.ClientIP(), ticket.Hash, err)
|
|
s.sendError(types.ErrInvalidFeeTx, c)
|
|
return
|
|
}
|
|
|
|
err = blockchain.CheckTransactionSanity(feeTx, s.cfg.NetParams)
|
|
if err != nil {
|
|
s.log.Warnf("%s: Fee tx failed sanity check (clientIP=%s, ticketHash=%s): %v",
|
|
funcName, c.ClientIP(), ticket.Hash, err)
|
|
s.sendError(types.ErrInvalidFeeTx, c)
|
|
return
|
|
}
|
|
|
|
// Decode fee address to get its payment script details.
|
|
feeAddr, err := stdaddr.DecodeAddress(ticket.FeeAddress, s.cfg.NetParams)
|
|
if err != nil {
|
|
s.log.Errorf("%s: Failed to decode fee address (ticketHash=%s): %v",
|
|
funcName, ticket.Hash, err)
|
|
s.sendError(types.ErrInternalError, c)
|
|
return
|
|
}
|
|
|
|
wantScriptVer, wantScript := feeAddr.PaymentScript()
|
|
|
|
// Confirm the provided fee transaction contains an output which pays to the
|
|
// expected payment script. Both script and script version should match.
|
|
var feePaid dcrutil.Amount
|
|
for _, txOut := range feeTx.TxOut {
|
|
if txOut.Version == wantScriptVer && bytes.Equal(txOut.PkScript, wantScript) {
|
|
feePaid = dcrutil.Amount(txOut.Value)
|
|
break
|
|
}
|
|
}
|
|
|
|
// Confirm a fee payment was found.
|
|
if feePaid == 0 {
|
|
s.log.Warnf("%s: Fee tx did not include expected payment (ticketHash=%s, feeAddress=%s, clientIP=%s)",
|
|
funcName, ticket.Hash, ticket.FeeAddress, c.ClientIP())
|
|
s.sendErrorWithMsg(
|
|
fmt.Sprintf("feetx did not include any payments for fee address %s", ticket.FeeAddress),
|
|
types.ErrInvalidFeeTx, c)
|
|
return
|
|
}
|
|
|
|
// Confirm fee payment is equal to or larger than the minimum expected.
|
|
minFee := dcrutil.Amount(ticket.FeeAmount)
|
|
if feePaid < minFee {
|
|
s.log.Warnf("%s: Fee too small (ticketHash=%s, clientIP=%s): was %s, expected minimum %s",
|
|
funcName, ticket.Hash, c.ClientIP(), feePaid, minFee)
|
|
s.sendError(types.ErrFeeTooSmall, c)
|
|
return
|
|
}
|
|
|
|
// Decode the provided voting WIF to get its voting rights script.
|
|
pkHash := stdaddr.Hash160(votingWIF.PubKey())
|
|
wifAddr, err := stdaddr.NewAddressPubKeyHashEcdsaSecp256k1V0(pkHash, s.cfg.NetParams)
|
|
if err != nil {
|
|
s.log.Errorf("%s: Failed to get voting address from WIF (ticketHash=%s, clientIP=%s): %v",
|
|
funcName, ticket.Hash, c.ClientIP(), err)
|
|
s.sendError(types.ErrInvalidPrivKey, c)
|
|
return
|
|
}
|
|
|
|
wantScriptVer, wantScript = wifAddr.VotingRightsScript()
|
|
|
|
// Decode ticket transaction to get its voting rights script.
|
|
ticketTx, err := decodeTransaction(rawTicket.Hex)
|
|
if err != nil {
|
|
s.log.Warnf("%s: Failed to decode ticket hex (ticketHash=%s): %v",
|
|
funcName, ticket.Hash, err)
|
|
s.sendError(types.ErrInternalError, c)
|
|
return
|
|
}
|
|
|
|
actualScriptVer := ticketTx.TxOut[0].Version
|
|
actualScript := ticketTx.TxOut[0].PkScript
|
|
|
|
// Ensure provided voting WIF matches the actual voting address of the
|
|
// ticket. Both script and script version should match.
|
|
if actualScriptVer != wantScriptVer || !bytes.Equal(actualScript, wantScript) {
|
|
s.log.Warnf("%s: Voting address does not match provided private key: (ticketHash=%s)",
|
|
funcName, ticket.Hash)
|
|
s.sendErrorWithMsg("voting address does not match provided private key",
|
|
types.ErrInvalidPrivKey, c)
|
|
return
|
|
}
|
|
|
|
// At this point we are satisfied that the request is valid and the fee tx
|
|
// pays sufficient fees to the expected address. Proceed to update the
|
|
// database, and if the ticket is confirmed broadcast the fee transaction.
|
|
|
|
ticket.VotingWIF = votingWIF.String()
|
|
ticket.FeeTxHex = request.FeeTx
|
|
ticket.FeeTxHash = feeTx.TxHash().String()
|
|
ticket.FeeTxStatus = database.FeeReceieved
|
|
|
|
if validVoteChoices {
|
|
ticket.VoteChoices = request.VoteChoices
|
|
}
|
|
|
|
if validTSpend {
|
|
ticket.TSpendPolicy = request.TSpendPolicy
|
|
}
|
|
|
|
if validTreasury {
|
|
ticket.TreasuryPolicy = request.TreasuryPolicy
|
|
}
|
|
|
|
err = s.db.UpdateTicket(ticket)
|
|
if err != nil {
|
|
s.log.Errorf("%s: db.UpdateTicket error, failed to set fee tx (ticketHash=%s): %v",
|
|
funcName, ticket.Hash, err)
|
|
s.sendError(types.ErrInternalError, c)
|
|
return
|
|
}
|
|
|
|
s.log.Debugf("%s: Fee tx received for ticket (minExpectedFee=%v, feePaid=%v, ticketHash=%s)",
|
|
funcName, minFee, feePaid, ticket.Hash)
|
|
|
|
if ticket.Confirmed {
|
|
err = dcrdClient.SendRawTransaction(request.FeeTx)
|
|
if err != nil {
|
|
s.log.Errorf("%s: dcrd.SendRawTransaction for fee tx failed (ticketHash=%s): %v",
|
|
funcName, ticket.Hash, err)
|
|
|
|
ticket.FeeTxStatus = database.FeeError
|
|
|
|
if strings.Contains(err.Error(),
|
|
"references outputs of unknown or fully-spent transaction") {
|
|
s.sendError(types.ErrCannotBroadcastFeeUnknownOutputs, c)
|
|
} else {
|
|
s.sendError(types.ErrCannotBroadcastFee, c)
|
|
}
|
|
|
|
err = s.db.UpdateTicket(ticket)
|
|
if err != nil {
|
|
s.log.Errorf("%s: db.UpdateTicket error, failed to set fee tx error (ticketHash=%s): %v",
|
|
funcName, ticket.Hash, err)
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
ticket.FeeTxStatus = database.FeeBroadcast
|
|
|
|
err = s.db.UpdateTicket(ticket)
|
|
if err != nil {
|
|
s.log.Errorf("%s: db.UpdateTicket error, failed to set fee tx as broadcast (ticketHash=%s): %v",
|
|
funcName, ticket.Hash, err)
|
|
s.sendError(types.ErrInternalError, c)
|
|
return
|
|
}
|
|
|
|
s.log.Debugf("%s: Fee tx broadcast for ticket (ticketHash=%s, feeHash=%s)",
|
|
funcName, ticket.Hash, ticket.FeeTxHash)
|
|
}
|
|
|
|
// Send success response to client.
|
|
resp, respSig := s.sendJSONResponse(types.PayFeeResponse{
|
|
Timestamp: time.Now().Unix(),
|
|
Request: reqBytes,
|
|
}, c)
|
|
|
|
// Store a record of the vote choice change.
|
|
err = s.db.SaveVoteChange(
|
|
ticket.Hash,
|
|
database.VoteChangeRecord{
|
|
Request: string(reqBytes),
|
|
RequestSignature: c.GetHeader("VSP-Client-Signature"),
|
|
Response: resp,
|
|
ResponseSignature: respSig,
|
|
})
|
|
if err != nil {
|
|
s.log.Errorf("%s: Failed to store vote change record (ticketHash=%s): %v", err)
|
|
}
|
|
}
|