ac488464c0
* Rework client/server authentication. - Remove Signature from all requests, and instead expect a signature in HTTP header "VSP-Client-Signature". - Remove CommitmentSignatures from the database. - Use a bool flag to indicate when a ticket is missing from the database rather than an error. This commit introduces a lot of duplication into each of the authenticated HTTP handlers. This should be removed in future work which moves the authentication to a dedicated middleware. * Introduce auth and rpc middleware. This removed the duplication added in the previous commit, and also removes the duplication of RPC client error handling.
72 lines
2.2 KiB
Go
72 lines
2.2 KiB
Go
package webapi
|
|
|
|
import (
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/gin-gonic/gin/binding"
|
|
"github.com/jholdstock/dcrvsp/database"
|
|
"github.com/jholdstock/dcrvsp/rpc"
|
|
)
|
|
|
|
// setVoteChoices is the handler for "POST /setvotechoices".
|
|
func setVoteChoices(c *gin.Context) {
|
|
|
|
// Get values which have been added to context by middleware.
|
|
rawRequest := c.MustGet("RawRequest").([]byte)
|
|
ticket := c.MustGet("Ticket").(database.Ticket)
|
|
knownTicket := c.MustGet("KnownTicket").(bool)
|
|
vWalletClient := c.MustGet("VotingWalletClient").(*rpc.VotingWalletRPC)
|
|
|
|
if !knownTicket {
|
|
log.Warnf("Invalid ticket from %s", c.ClientIP())
|
|
sendErrorResponse("invalid ticket", http.StatusBadRequest, c)
|
|
return
|
|
}
|
|
|
|
var setVoteChoicesRequest SetVoteChoicesRequest
|
|
if err := binding.JSON.BindBody(rawRequest, &setVoteChoicesRequest); err != nil {
|
|
log.Warnf("Bad setvotechoices request from %s: %v", c.ClientIP(), err)
|
|
sendErrorResponse(err.Error(), http.StatusBadRequest, c)
|
|
return
|
|
}
|
|
|
|
voteChoices := setVoteChoicesRequest.VoteChoices
|
|
err := isValidVoteChoices(cfg.NetParams, currentVoteVersion(cfg.NetParams), voteChoices)
|
|
if err != nil {
|
|
log.Warnf("Invalid votechoices from %s: %v", c.ClientIP(), err)
|
|
sendErrorResponse(err.Error(), http.StatusBadRequest, c)
|
|
return
|
|
}
|
|
|
|
// Update VoteChoices in the database before updating the wallets. DB is
|
|
// source of truth and is less likely to error.
|
|
err = db.UpdateVoteChoices(ticket.Hash, voteChoices)
|
|
if err != nil {
|
|
log.Errorf("UpdateVoteChoices error: %v", err)
|
|
sendErrorResponse("database error", http.StatusInternalServerError, c)
|
|
return
|
|
}
|
|
|
|
// Update vote choices on voting wallets.
|
|
for agenda, choice := range voteChoices {
|
|
err = vWalletClient.SetVoteChoice(agenda, choice, ticket.Hash)
|
|
if err != nil {
|
|
log.Errorf("SetVoteChoice failed: %v", err)
|
|
sendErrorResponse("dcrwallet RPC error", http.StatusInternalServerError, c)
|
|
return
|
|
}
|
|
}
|
|
|
|
// TODO: DB - error if given timestamp is older than any previous requests
|
|
|
|
// TODO: DB - store setvotechoices receipt in log
|
|
|
|
sendJSONResponse(setVoteChoicesResponse{
|
|
Timestamp: time.Now().Unix(),
|
|
Request: setVoteChoicesRequest,
|
|
VoteChoices: voteChoices,
|
|
}, c)
|
|
}
|