4f2766352b
- Fee tx status is now tracked using a dedicated field, with values none/received/broadcast/confirmed/error. - Fee tx hex and hash are now both set in /payfee. The absense of txhash is no longer used to determine if a fee tx has been broadcast or not. - setvotechoices can no longer be called before a fee is received. - Remove `binding:required` from response types. It has no effect on responses, it is only needed on request types which are validated by gin.
86 lines
2.6 KiB
Go
86 lines
2.6 KiB
Go
package webapi
|
|
|
|
import (
|
|
"time"
|
|
|
|
"github.com/decred/vspd/database"
|
|
"github.com/decred/vspd/rpc"
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/gin-gonic/gin/binding"
|
|
)
|
|
|
|
// setVoteChoices is the handler for "POST /setvotechoices".
|
|
func setVoteChoices(c *gin.Context) {
|
|
|
|
// Get values which have been added to context by middleware.
|
|
rawRequest := c.MustGet("RawRequest").([]byte)
|
|
ticket := c.MustGet("Ticket").(database.Ticket)
|
|
knownTicket := c.MustGet("KnownTicket").(bool)
|
|
walletClients := c.MustGet("WalletClients").([]*rpc.WalletRPC)
|
|
|
|
if !knownTicket {
|
|
log.Warnf("Unknown ticket from %s", c.ClientIP())
|
|
sendError(errUnknownTicket, c)
|
|
return
|
|
}
|
|
|
|
if ticket.FeeTxStatus == database.NoFee {
|
|
log.Warnf("Setvotechoices without fee tx from %s", c.ClientIP())
|
|
sendError(errFeeNotReceived, c)
|
|
return
|
|
}
|
|
|
|
var setVoteChoicesRequest SetVoteChoicesRequest
|
|
if err := binding.JSON.BindBody(rawRequest, &setVoteChoicesRequest); err != nil {
|
|
log.Warnf("Bad setvotechoices request from %s: %v", c.ClientIP(), err)
|
|
sendErrorWithMsg(err.Error(), errBadRequest, c)
|
|
return
|
|
}
|
|
|
|
voteChoices := setVoteChoicesRequest.VoteChoices
|
|
err := isValidVoteChoices(cfg.NetParams, currentVoteVersion(cfg.NetParams), voteChoices)
|
|
if err != nil {
|
|
log.Warnf("Invalid votechoices from %s: %v", c.ClientIP(), err)
|
|
sendErrorWithMsg(err.Error(), errInvalidVoteChoices, c)
|
|
return
|
|
}
|
|
|
|
// Update VoteChoices in the database before updating the wallets. DB is
|
|
// source of truth and is less likely to error.
|
|
ticket.VoteChoices = voteChoices
|
|
err = db.UpdateTicket(ticket)
|
|
if err != nil {
|
|
log.Errorf("UpdateTicket error: %v", err)
|
|
sendError(errInternalError, c)
|
|
return
|
|
}
|
|
|
|
// Update vote choices on voting wallets. Tickets are only added to voting
|
|
// wallets if their fee is confirmed.
|
|
if ticket.FeeTxStatus == database.FeeConfirmed {
|
|
for agenda, choice := range voteChoices {
|
|
for _, walletClient := range walletClients {
|
|
err = walletClient.SetVoteChoice(agenda, choice, ticket.Hash)
|
|
// TODO: This will error if the wallet does not know about the ticket yet.
|
|
// TODO: We shouldn't return on first error - we want to try all wallets.
|
|
if err != nil {
|
|
// If this fails, we still want to try the other wallets, so
|
|
// don't return an error response, just log an error.
|
|
log.Errorf("SetVoteChoice failed: %v", err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
log.Debugf("Vote choices updated for ticket: ticketHash=%s", ticket.Hash)
|
|
|
|
// TODO: DB - error if given timestamp is older than any previous requests
|
|
|
|
// TODO: DB - store setvotechoices receipt in log
|
|
|
|
sendJSONResponse(setVoteChoicesResponse{
|
|
Timestamp: time.Now().Unix(),
|
|
Request: setVoteChoicesRequest,
|
|
}, c)
|
|
}
|