stakey/vspd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix backup file mode

Browse Source
This commit is contained in:
jholdstock 2020-08-09 10:30:55 +01:00 committed by David Hill
parent 6c12ddeb31
commit e2483b6cea
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
database/database.go
View File

@ -43,6 +43,11 @@ var (
lastAddressIndexK = []byte("lastaddressindex") lastAddressIndexK = []byte("lastaddressindex")
) )
const (
// backupFileMode is the file mode for database backup files written by vspd.
backupFileMode = 0600
)
// backupMtx should be held when writing to the database backup file // backupMtx should be held when writing to the database backup file
var backupMtx sync.Mutex var backupMtx sync.Mutex
@ -57,7 +62,7 @@ func writeHotBackupFile(db *bolt.DB) error {
// Write backup to temporary file. // Write backup to temporary file.
err := db.View(func(tx *bolt.Tx) error { err := db.View(func(tx *bolt.Tx) error {
return tx.CopyFile(tempPath, 0600) return tx.CopyFile(tempPath, backupFileMode)
}) })
if err != nil { if err != nil {
return fmt.Errorf("tx.CopyFile: %v", err) return fmt.Errorf("tx.CopyFile: %v", err)
@ -229,7 +234,7 @@ func (vdb *VspDatabase) Close() {
} }
defer from.Close() defer from.Close()
to, err := os.OpenFile(tempPath, os.O_RDWR|os.O_CREATE, 0666) to, err := os.OpenFile(tempPath, os.O_RDWR|os.O_CREATE, backupFileMode)
if err != nil { if err != nil {
log.Errorf("Failed to write a database backup (os.OpenFile): %v", err) log.Errorf("Failed to write a database backup (os.OpenFile): %v", err)
return return